Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use webview instead of iframe for changelly #1277

merged 1 commit into from Jun 6, 2019


None yet
5 participants
Copy link

commented Jun 5, 2019

Fixes the changelly widget issue about not being allowed on the domain. Resolves #1275

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #1277 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1277   +/-   ##
  Coverage     40.2%   40.2%           
  Files          232     232           
  Lines         6372    6372           
  Branches      1248    1255    +7     
  Hits          2562    2562           
+ Misses        3589    3588    -1     
- Partials       221     222    +1
Impacted Files Coverage Δ
...omponents/Wallet/WalletExchange/WalletExchange.vue 18.18% <ø> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 29.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d582c...1f85c72. Read the comment docs.

@luciorubeens luciorubeens merged commit d2c786d into develop Jun 6, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the fix/changelly-widget branch Jun 6, 2019

alexbarnsley added a commit that referenced this pull request Jun 12, 2019

v2.4.1 (#1284)
* fix: use webview instead of iframe for changelly (#1277)

* refactor: correct config endpoint order

* chore: update @arkecosystem/client

* hotfix: get fees for 7 days instead of 30

* chore: bump to 2.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.