Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated key warning on new wallet page #1294

Merged
merged 4 commits into from Jun 24, 2019

Conversation

Projects
None yet
5 participants
@j-a-m-l
Copy link
Contributor

commented Jun 19, 2019

The wallet creation page throws several errors on the console tagged as Vue warnings.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #1294 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1294   +/-   ##
========================================
  Coverage    39.97%   39.97%           
========================================
  Files          228      228           
  Lines         6321     6321           
  Branches      1239     1239           
========================================
  Hits          2527     2527           
  Misses        3573     3573           
  Partials       221      221
Impacted Files Coverage Δ
src/renderer/pages/Wallet/WalletNew.vue 40.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c5c9a...e93a6d0. Read the comment docs.

Update src/renderer/pages/Wallet/WalletNew.vue
Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>

@alexbarnsley alexbarnsley changed the title fix: duplicated key warning on `WalletNew` fix: duplicated key warning on new wallet page Jun 24, 2019

@alexbarnsley alexbarnsley merged commit 4c7a3ce into develop Jun 24, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-duplicated-key-warning branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.