Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop to master #1304

Merged
merged 57 commits into from Jun 26, 2019

Conversation

Projects
None yet
@alexbarnsley
Copy link
Member

commented Jun 26, 2019

No description provided.

alexbarnsley and others added some commits Apr 3, 2019

fix: `InputSelect` dropdowns (#1174)
* fix: `InputSelect` dropdowns

* refactor: use the new Vue 2.6 syntax for named slots

* fix: do not allow more than 1 `InputSelect` open at the same time
fix: add network modal validation (#1173)
* fix: network validation being overwritten

* feat: pull active delegates from api

* fix: make sure active delegates value exists

* refactor: improve server regex

* test: network modal for adding network

* chore: replace todo with comment

* fix: use one loop with prefilled values as backup

* refactor: allow string or number for input text

* refactor: allow fetching fees for specific network

* fix: fetch network fees when adding/editing

* fix: fetch fees & wait before add/update

alexbarnsley and others added some commits Jun 17, 2019

Update src/renderer/pages/Wallet/WalletNew.vue
Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>
fix: ledger options on build (#1300)
* fix: ledger options on build

* fix: use component directly
fix: duplicated key warning on new wallet page (#1294)
fix: duplicated key warning on `WalletNew`
fix: don't close custom peer modal when clicking inside (#1204)
* refactor: rename `NetworkCustomPeer` to `NetworkCustomPeerModal`

* fix: do not close the custom peer modal when clicking inside it
fix: ledger whitescreen (#1296)
* fix: ledger whitescreen errors

* refactor: all ledger errors are failures

* refactor: improve ledger connection check

* refactor: improve ledger & use hid-singleton

* test: fix failing

* chore: remove e2e tests
fix: open transaction modal on dashboard (#1281)
* fix: remove deeplink validation prefix

* fix: open transaction modal on dashboard
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@40bd89b). Click here to learn what that means.
The diff coverage is 41.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1304   +/-   ##
=========================================
  Coverage          ?   39.93%           
=========================================
  Files             ?      228           
  Lines             ?     6338           
  Branches          ?     1245           
=========================================
  Hits              ?     2531           
  Misses            ?     3586           
  Partials          ?      221
Impacted Files Coverage Δ
...er/components/Menu/MenuOptions/MenuOptionsItem.vue 66.66% <ø> (ø)
...erer/components/Network/NetworkCustomPeerModal.vue 24.48% <ø> (ø)
...enderer/components/Transaction/TransactionShow.vue 47.05% <ø> (ø)
src/renderer/components/Button/ButtonModal.vue 50% <ø> (ø)
...ponents/Menu/MenuNavigation/MenuNavigationItem.vue 57.14% <ø> (ø)
src/renderer/mixins/index.js 0% <ø> (ø)
...nderer/components/Modal/ModalAdditionalLedgers.vue 47.82% <ø> (ø)
.../components/Menu/MenuDropdown/MenuDropdownItem.vue 100% <ø> (ø)
...derer/components/Transaction/TransactionAmount.vue 25% <ø> (ø)
...mponents/Menu/MenuDropdown/MenuDropdownHandler.vue 75% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40bd89b...3e63cbc. Read the comment docs.

@alexbarnsley alexbarnsley merged commit c231579 into master Jun 26, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.