Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar popup button click to close #1305

merged 2 commits into from Jun 27, 2019


Copy link

commented Jun 26, 2019

Fixes an issue where re-clicking the sidebar button (e.g. settings) to close the popup doesn't work.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #1305 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1305      +/-   ##
+ Coverage    39.93%   39.94%   +<.01%     
  Files          228      228              
  Lines         6338     6337       -1     
  Branches      1252     1252              
  Hits          2531     2531              
+ Misses        3585     3584       -1     
  Partials       222      222
Impacted Files Coverage Δ
...enderer/components/App/AppSidemenu/AppSidemenu.vue 0% <ø> (ø) ⬆️
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <0%> (ø) ⬆️
...nents/App/AppSidemenu/AppSidemenuNetworkStatus.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6857e...c5a963e. Read the comment docs.

@j-a-m-l j-a-m-l merged commit 961f144 into develop Jun 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the fix/sidebar-popup-click-close branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.