Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add tooltip to wallet name #1309

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@kalgoop
Copy link
Contributor

commented Jul 1, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #1309 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1309   +/-   ##
========================================
  Coverage    39.84%   39.84%           
========================================
  Files          229      229           
  Lines         6354     6354           
  Branches      1249     1256    +7     
========================================
  Hits          2532     2532           
+ Misses        3601     3600    -1     
- Partials       221      222    +1
Impacted Files Coverage Δ
...ponents/Wallet/WalletHeading/WalletHeadingInfo.vue 62.16% <100%> (ø) ⬆️
src/renderer/components/Network/NetworkModal.vue 29.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990789f...2ae9623. Read the comment docs.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@luciorubeens luciorubeens merged commit aa414dc into ArkEcosystem:develop Jul 3, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Your pull request has been merged and marked as tier 5. It will earn you $5 USD.

@dated dated referenced this pull request Jul 3, 2019
5 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.