Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use bip38@2.0.3 to support electron v4 and later #1351

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@faustbrian
Copy link
Contributor

commented Aug 5, 2019

bitcoinjs/bip38@5e74985

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #1351 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1351   +/-   ##
=======================================
  Coverage     39.8%   39.8%           
=======================================
  Files          235     235           
  Lines         6336    6336           
  Branches      1243    1243           
=======================================
  Hits          2522    2522           
  Misses        3600    3600           
  Partials       214     214

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6e2ef...e8bf8c2. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 5ce2840 into develop Aug 5, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
security/snyk - package.json (ArkEcosystem) No new issues
Details

@alexbarnsley alexbarnsley deleted the deps/bip38 branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.