Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore - test only #1528

Closed
wants to merge 120 commits into from

Conversation

@faustbrian
Copy link
Contributor

faustbrian commented Nov 1, 2019

No description provided.

alexbarnsley added 30 commits Sep 11, 2019
* refactor: rename error variable

* refactor: move stuff to mixin

* refactor: move validation to mixin

* fix: build vote transaction

* fix: when to call postSubmit

* fix: delegate username validation
faustbrian and others added 20 commits Oct 28, 2019
…allet into feat/2.6-tx-types
faustbrian added 2 commits Nov 1, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #1528 into develop will decrease coverage by 1.71%.
The diff coverage is 21.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1528      +/-   ##
===========================================
- Coverage    45.44%   43.73%   -1.72%     
===========================================
  Files          274      295      +21     
  Lines         6806     7566     +760     
  Branches      1326     1472     +146     
===========================================
+ Hits          3093     3309     +216     
- Misses        3550     4057     +507     
- Partials       163      200      +37
Impacted Files Coverage Δ
src/renderer/components/Input/InputCurrency.vue 59.63% <ø> (-1.69%) ⬇️
src/renderer/components/Modal/ModalWindow.vue 76.47% <ø> (ø) ⬆️
src/renderer/components/Menu/MenuTab/MenuTab.vue 78.57% <ø> (ø) ⬆️
...ctionConfirm/TransactionConfirmSecondSignature.vue 75% <ø> (ø) ⬆️
...nu/MenuDropdown/MenuDropdownAlternativeHandler.vue 100% <ø> (ø) ⬆️
src/renderer/models/network.js 100% <ø> (ø) ⬆️
...mponents/Menu/MenuDropdown/MenuDropdownHandler.vue 75% <ø> (ø) ⬆️
src/renderer/models/wallet.js 100% <ø> (ø) ⬆️
...nents/Wallet/WalletSignVerify/WalletSignVerify.vue 20% <ø> (ø) ⬆️
src/renderer/services/synchronizer.js 20.28% <ø> (ø) ⬆️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16958b3...09712f6. Read the comment docs.

faustbrian added 2 commits Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.