From 3163eecfb23e50018cd8e41793519db30f28f1ae Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Thu, 30 Jan 2020 14:40:56 +0100
Subject: [PATCH] refactor: scroll on menu tab, not on container

---
 src/renderer/components/Menu/MenuTab/MenuTab.vue     | 12 ++++++++----
 .../Wallet/WalletDetails/WalletDetails.vue           |  7 ++-----
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/renderer/components/Menu/MenuTab/MenuTab.vue b/src/renderer/components/Menu/MenuTab/MenuTab.vue
index 9418f6f520..bbb065f3d1 100644
--- a/src/renderer/components/Menu/MenuTab/MenuTab.vue
+++ b/src/renderer/components/Menu/MenuTab/MenuTab.vue
@@ -24,7 +24,7 @@
         </button>
       </div>
     </nav>
-    <section class="MenuTab__content p-5">
+    <section class="MenuTab__content p-5 overflow-y-auto">
       <slot />
     </section>
   </div>
@@ -92,8 +92,12 @@ export default {
 </script>
 
 <style lang="postcss" scoped>
+.MenuTab {
+  @apply .flex .flex-col .h-full;
+}
+
 .MenuTab__nav__item--active {
-  @apply .bg-theme-feature .text-theme-page-text
+  @apply .bg-theme-feature .text-theme-page-text;
 }
 
 .MenuTab__nav__item--clickable {
@@ -101,10 +105,10 @@ export default {
 }
 
 .MenuTab__nav__item--disabled {
-  @apply .text-theme-feature-item-alternative-text .opacity-50
+  @apply .text-theme-feature-item-alternative-text .opacity-50;
 }
 
 .MenuTab__nav__item--disabled:hover {
-  @apply .bg-transparent
+  @apply .bg-transparent;
 }
 </style>
diff --git a/src/renderer/components/Wallet/WalletDetails/WalletDetails.vue b/src/renderer/components/Wallet/WalletDetails/WalletDetails.vue
index a004bbf75a..b5c6958846 100644
--- a/src/renderer/components/Wallet/WalletDetails/WalletDetails.vue
+++ b/src/renderer/components/Wallet/WalletDetails/WalletDetails.vue
@@ -1,12 +1,12 @@
 <template>
   <main class="WalletDetails flex flex-col">
-    <WalletHeading class="sticky pin-t z-10" />
+    <WalletHeading />
 
     <MenuTab
       ref="menutab"
       v-model="currentTab"
       :class="{ 'rounded-bl-lg' : !isDelegatesTab || !isOwned }"
-      class="flex-1 overflow-y-auto"
+      class="flex-1"
     >
       <MenuTabItem
         key="BackItem"
@@ -481,9 +481,6 @@ export default {
 </script>
 
 <style lang="postcss">
-.WalletDetails .MenuTab > .MenuTab__nav {
-  @apply .sticky .pin-t .z-10
-}
 .WalletDetails__button {
   transition: 0.5s;
   cursor: pointer;