From e836760c3d911af4479283b5ec6cdd2344542958 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Fri, 28 Feb 2020 19:10:31 +0100
Subject: [PATCH 01/12] refactor: adjust business transaction form validation

---
 .../TransactionFormBusiness/mixin.vue         | 57 ++++++++++++++++++-
 src/renderer/services/client.js               | 30 +---------
 2 files changed, 57 insertions(+), 30 deletions(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
index 1f60ab69e4..8786ef29cb 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
@@ -100,7 +100,7 @@
       />
 
       <button
-        :disabled="$v.form.$invalid"
+        :disabled="!isFormValid"
         class="TransactionFormBusiness__next blue-button mt-10 ml-0"
         @click="onSubmit"
       >
@@ -161,10 +161,53 @@ export default {
   }),
 
   computed: {
+    business () {
+      return this.wallet_fromRoute.business
+    },
+
+    isUpdate () {
+      return !!this.business
+    },
+
+    hasSameName () {
+      return this.form.asset.name === this.business.name
+    },
+
+    hasSameWebsite () {
+      return this.form.asset.website === this.business.website
+    },
+
+    hasSameVat () {
+      return (
+        this.form.asset.vat === this.business.vat ||
+        !!this.form.asset.vat === !!this.business.vat
+      )
+    },
+
+    hasSameRepository () {
+      return (
+        this.form.asset.repository === this.business.repository ||
+        !!this.form.asset.repository === !!this.business.repository
+      )
+    },
+
     nameLabel () {
       return `${this.$t('WALLET_BUSINESS.NAME')} - ${this.$t('VALIDATION.MAX_LENGTH', [maxNameLength])}`
     },
 
+    isFormValid () {
+      if (this.isUpdate) {
+        return !this.$v.form.$invalid && !(
+          this.hasSameName &&
+          this.hasSameWebsite &&
+          this.hasSameVat &&
+          this.hasSameRepository
+        )
+      }
+
+      return !this.$v.form.$invalid
+    },
+
     nameError () {
       if (this.$v.form.asset.name.$dirty && this.$v.form.asset.name.$invalid) {
         if (!this.$v.form.asset.name.required) {
@@ -226,9 +269,19 @@ export default {
 
   methods: {
     getTransactionData () {
+      const businessAsset = Object.assign({}, this.form.asset)
+
+      if (this.isUpdate) {
+        for (const property of Object.keys(this.form.asset)) {
+          if (this[`hasSame${this.strings_capitalizeFirst(property)}`]) {
+            delete businessAsset[property]
+          }
+        }
+      }
+
       const transactionData = {
         address: this.currentWallet.address,
-        asset: this.form.asset,
+        asset: businessAsset,
         passphrase: this.form.passphrase,
         fee: this.getFee(),
         wif: this.form.wif,
diff --git a/src/renderer/services/client.js b/src/renderer/services/client.js
index 3f74ee0068..a3350c8de0 100644
--- a/src/renderer/services/client.js
+++ b/src/renderer/services/client.js
@@ -930,21 +930,8 @@ export default class ClientService {
       throw new Error(`Business Registration fee should be smaller than ${staticFee}`)
     }
 
-    const businessRegistrationAsset = {
-      name: asset.name,
-      website: asset.website
-    }
-
-    if (asset.vat && asset.vat.length) {
-      businessRegistrationAsset.vat = asset.vat
-    }
-
-    if (asset.repository && asset.repository.length) {
-      businessRegistrationAsset.repository = asset.repository
-    }
-
     const transaction = new MagistrateCrypto.Builders.BusinessRegistrationBuilder()
-      .businessRegistrationAsset(businessRegistrationAsset)
+      .businessRegistrationAsset(asset)
       .fee(fee)
 
     passphrase = this.normalizePassphrase(passphrase)
@@ -999,21 +986,8 @@ export default class ClientService {
       throw new Error(`Business Update fee should be smaller than ${staticFee}`)
     }
 
-    const businessAsset = {
-      name: asset.name,
-      website: asset.website
-    }
-
-    if (asset.vat && asset.vat.length) {
-      businessAsset.vat = asset.vat
-    }
-
-    if (asset.repository && asset.repository.length) {
-      businessAsset.repository = asset.repository
-    }
-
     const transaction = new MagistrateCrypto.Builders.BusinessUpdateBuilder()
-      .businessUpdateAsset(businessAsset)
+      .businessUpdateAsset(asset)
       .fee(fee)
 
     passphrase = this.normalizePassphrase(passphrase)

From 240949aef1d907c49b84a8ad31b1d4bfbcc59d1c Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Fri, 28 Feb 2020 19:10:39 +0100
Subject: [PATCH 02/12] refactor: only show available fields in business
 confirmation modal

---
 .../TransactionConfirmBusinessUpdate.vue                        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/renderer/components/Transaction/TransactionConfirm/TransactionConfirmBusiness/TransactionConfirmBusinessUpdate.vue b/src/renderer/components/Transaction/TransactionConfirm/TransactionConfirmBusiness/TransactionConfirmBusinessUpdate.vue
index fc509792a7..7bd43dfdc5 100644
--- a/src/renderer/components/Transaction/TransactionConfirm/TransactionConfirmBusiness/TransactionConfirmBusinessUpdate.vue
+++ b/src/renderer/components/Transaction/TransactionConfirm/TransactionConfirmBusiness/TransactionConfirmBusinessUpdate.vue
@@ -17,6 +17,7 @@
     </ListDividedItem>
 
     <ListDividedItem
+      v-if="transaction.asset.businessUpdate.name"
       class="TransactionConfirmBusinessUpdate__name"
       :label="$t('WALLET_BUSINESS.NAME')"
     >
@@ -24,6 +25,7 @@
     </ListDividedItem>
 
     <ListDividedItem
+      v-if="transaction.asset.businessUpdate.website"
       class="TransactionConfirmBusinessUpdate__website"
       :label="$t('WALLET_BUSINESS.WEBSITE')"
     >

From ac656582ba0e758a6e42a8a7cf1d7251361a6608 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Fri, 28 Feb 2020 20:13:24 +0100
Subject: [PATCH 03/12] test: adjust unit tests

---
 .../TransactionFormBusiness/mixin.spec.js     | 40 +++++++++++++------
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
index ddc107d649..618166ec85 100644
--- a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
+++ b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
@@ -5,6 +5,7 @@ import installI18n from '../../../../__utils__/i18n'
 import TransactionFormBusinessRegistration from '@/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessRegistration'
 import TransactionFormBusinessUpdate from '@/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessUpdate'
 import CurrencyMixin from '@/mixins/currency'
+import StringMixin from '@/mixins/strings'
 import BigNumber from '@/plugins/bignumber'
 
 const localVue = createLocalVue()
@@ -42,6 +43,7 @@ const createWrapper = (component, wallet_fromRoute) => {
     i18n,
     localVue,
     sync: false,
+    mixins: [StringMixin],
     mocks: {
       $client: {
         buildBusinessRegistration: jest.fn((transactionData) => transactionData),
@@ -195,7 +197,7 @@ describe.each([
       it('should be enabled if form is valid', async () => {
         wrapper.vm.$v.form.fee.$model = (0.1 * 1e8).toString()
         wrapper.vm.$v.form.passphrase.$model = 'passphrase'
-        wrapper.vm.$v.form.asset.name.$model = 'business'
+        wrapper.vm.$v.form.asset.name.$model = 'new business'
         wrapper.vm.$v.form.asset.website.$model = 'https://ark.io'
         wrapper.vm.$v.form.asset.vat.$model = 'GB12345678'
         wrapper.vm.$v.form.asset.repository.$model = 'https://github.com/arkecosystem/desktop-wallet.git'
@@ -497,14 +499,20 @@ describe.each([
         wrapper.vm.$v.form.asset.vat.$model = 'GB12345678'
         wrapper.vm.$v.form.asset.repository.$model = 'https://github.com/arkecosystem/desktop-wallet.git'
 
+        let expectedAsset = {
+          name: 'business',
+          website: 'https://ark.io',
+          vat: 'GB12345678',
+          repository: 'https://github.com/arkecosystem/desktop-wallet.git'
+        }
+
+        if (componentName === 'TransactionFormBusinessUpdate') {
+          expectedAsset = {}
+        }
+
         expect(wrapper.vm.getTransactionData()).toEqual({
           address: 'address-1',
-          asset: {
-            name: 'business',
-            website: 'https://ark.io',
-            vat: 'GB12345678',
-            repository: 'https://github.com/arkecosystem/desktop-wallet.git'
-          },
+          asset: expectedAsset,
           passphrase: 'passphrase',
           fee: new BigNumber(0.1 * 1e8),
           wif: undefined,
@@ -528,14 +536,20 @@ describe.each([
         wrapper.vm.$v.form.asset.vat.$model = 'GB12345678'
         wrapper.vm.$v.form.asset.repository.$model = 'https://github.com/arkecosystem/desktop-wallet.git'
 
+        let expectedAsset = {
+          name: 'business',
+          website: 'https://ark.io',
+          vat: 'GB12345678',
+          repository: 'https://github.com/arkecosystem/desktop-wallet.git'
+        }
+
+        if (componentName === 'TransactionFormBusinessUpdate') {
+          expectedAsset = {}
+        }
+
         expect(wrapper.vm.getTransactionData()).toEqual({
           address: 'address-1',
-          asset: {
-            name: 'business',
-            website: 'https://ark.io',
-            vat: 'GB12345678',
-            repository: 'https://github.com/arkecosystem/desktop-wallet.git'
-          },
+          asset: expectedAsset,
           passphrase: 'passphrase',
           secondPassphrase: 'second passphrase',
           fee: new BigNumber(0.1 * 1e8),

From 4225fcc85fb7fdc8f7546720d4b512c8fe73f856 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Fri, 28 Feb 2020 20:47:04 +0100
Subject: [PATCH 04/12] test: adjust unit tests

---
 .../TransactionFormBusinessUpdate.spec.js                       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessUpdate.spec.js b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessUpdate.spec.js
index 1970a2dc31..248dfccc95 100644
--- a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessUpdate.spec.js
+++ b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/TransactionFormBusinessUpdate.spec.js
@@ -153,7 +153,7 @@ describe('TransactionFormBusinessUpdate', () => {
       it('should be enabled if form is valid', async () => {
         wrapper.vm.$v.form.fee.$model = (0.1 * 1e8).toString()
         wrapper.vm.$v.form.passphrase.$model = 'passphrase'
-        wrapper.vm.$v.form.asset.name.$model = 'business'
+        wrapper.vm.$v.form.asset.name.$model = 'new business'
         wrapper.vm.$v.form.asset.website.$model = 'https://ark.io'
         wrapper.vm.$v.form.asset.vat.$model = 'GB12345678'
         wrapper.vm.$v.form.asset.repository.$model = 'https://github.com/arkecosystem/desktop-wallet.git'

From 2a71c9cbc5f7862cef2ad4e16020600f900b0fc6 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:21:20 +0100
Subject: [PATCH 05/12] fix: require vat and repository on update and if
 already set on business

---
 .../TransactionFormBusiness/mixin.vue              | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
index 8786ef29cb..71b25740ae 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
@@ -240,7 +240,9 @@ export default {
 
     vatError () {
       if (this.$v.form.asset.vat.$dirty && this.$v.form.asset.vat.$invalid) {
-        if (!this.$v.form.asset.vat.tooShort) {
+        if (!this.$v.form.asset.vat.required) {
+          return this.$t('VALIDATION.REQUIRED', [this.$t('WALLET_BUSINESS.VAT')])
+        } else if (!this.$v.form.asset.vat.tooShort) {
           return this.$t('VALIDATION.TOO_SHORT', [this.$t('WALLET_BUSINESS.VAT')])
         } else if (!this.$v.form.asset.vat.tooLong) {
           return this.$t('VALIDATION.TOO_LONG', [this.$t('WALLET_BUSINESS.VAT')])
@@ -256,7 +258,9 @@ export default {
 
     repositoryError () {
       if (this.$v.form.asset.repository.$dirty && this.$v.form.asset.repository.$invalid) {
-        if (!this.$v.form.asset.repository.url) {
+        if (!this.$v.form.asset.repository.required) {
+          return this.$t('VALIDATION.REQUIRED', [this.$t('WALLET_BUSINESS.REPOSITORY')])
+        } else if (!this.$v.form.asset.repository.url) {
           return this.$t('VALIDATION.INVALID_URL')
         } else if (!this.$v.form.asset.repository.tooShort) {
           return this.$t('VALIDATION.TOO_SHORT', [this.$t('WALLET_BUSINESS.REPOSITORY')])
@@ -319,11 +323,17 @@ export default {
         },
 
         vat: {
+          required (value) {
+            return (this.business && this.business.vat) ? required(value) : true
+          },
           tooShort: minLength(minVatLength),
           tooLong: maxLength(maxVatLength)
         },
 
         repository: {
+          required (value) {
+            return (this.business && this.business.respository) ? required(value) : true
+          },
           tooShort: minLength(minRepositoryLength),
           url
         }

From ab03881ddade0684127a3821613888d04d986f15 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:25:15 +0100
Subject: [PATCH 06/12] fix: delete property if equal on update or if empty

---
 .../TransactionForm/TransactionFormBusiness/mixin.vue | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
index 71b25740ae..f04a4ad96a 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
@@ -275,11 +275,12 @@ export default {
     getTransactionData () {
       const businessAsset = Object.assign({}, this.form.asset)
 
-      if (this.isUpdate) {
-        for (const property of Object.keys(this.form.asset)) {
-          if (this[`hasSame${this.strings_capitalizeFirst(property)}`]) {
-            delete businessAsset[property]
-          }
+      for (const property of Object.keys(this.form.asset)) {
+        if (
+          (this.isUpdate && this[`hasSame${this.strings_capitalizeFirst(property)}`]) ||
+          !businessAsset[property].length
+        ) {
+          delete businessAsset[property]
         }
       }
 

From d97a5cd7c5c65e8124039502d5265ccbcee53ba4 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:39:27 +0100
Subject: [PATCH 07/12] fix: typo

---
 .../TransactionForm/TransactionFormBusiness/mixin.vue           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
index f04a4ad96a..02d873f102 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
@@ -333,7 +333,7 @@ export default {
 
         repository: {
           required (value) {
-            return (this.business && this.business.respository) ? required(value) : true
+            return (this.business && this.business.repository) ? required(value) : true
           },
           tooShort: minLength(minRepositoryLength),
           url

From d1ff3354a77a053944de458baafee177edead5ab Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:47:45 +0100
Subject: [PATCH 08/12] fix: hasSameVat and hasSameRepository check

---
 .../TransactionForm/TransactionFormBusiness/mixin.vue         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
index 02d873f102..11a9ea852f 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.vue
@@ -180,14 +180,14 @@ export default {
     hasSameVat () {
       return (
         this.form.asset.vat === this.business.vat ||
-        !!this.form.asset.vat === !!this.business.vat
+        (!this.form.asset.vat && (this.business.vat === undefined))
       )
     },
 
     hasSameRepository () {
       return (
         this.form.asset.repository === this.business.repository ||
-        !!this.form.asset.repository === !!this.business.repository
+        (!this.form.asset.repository && (this.business.repository === undefined))
       )
     },
 

From ef4d091376e4fcc6a6b4faf4683b984bae94daee Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:50:20 +0100
Subject: [PATCH 09/12] fix: optional bridgechain asset repository handling

---
 .../TransactionFormBridgechain/mixin.vue             | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/renderer/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.vue b/src/renderer/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.vue
index a4573449aa..f74d3da9aa 100644
--- a/src/renderer/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.vue
+++ b/src/renderer/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.vue
@@ -266,7 +266,10 @@ export default {
     },
 
     hasSameAssetRepository () {
-      return this.form.asset.bridgechainAssetRepository === this.bridgechain.bridgechainAssetRepository
+      return (
+        this.form.asset.bridgechainAssetRepository === this.bridgechain.bridgechainAssetRepository ||
+        (!this.form.asset.bridgechainAssetRepository && (this.bridgechain.bridgechainAssetRepository === undefined))
+      )
     },
 
     hasSameSeedNodes () {
@@ -343,7 +346,9 @@ export default {
 
     bridgechainAssetRepositoryError () {
       if (this.$v.form.asset.bridgechainAssetRepository.$dirty && this.$v.form.asset.bridgechainAssetRepository.$invalid) {
-        if (!this.$v.form.asset.bridgechainAssetRepository.url) {
+        if (!this.$v.form.asset.bridgechainAssetRepository.required) {
+          return this.$t('VALIDATION.REQUIRED', [this.$t('TRANSACTION.BRIDGECHAIN.BRIDGECHAIN_ASSET_REPOSITORY')])
+        } else if (!this.$v.form.asset.bridgechainAssetRepository.url) {
           return this.$t('VALIDATION.INVALID_URL')
         }
       }
@@ -576,6 +581,9 @@ export default {
         },
 
         bridgechainAssetRepository: {
+          required (value) {
+            return (this.bridgechain && this.bridgechain.bridgechainAssetRepository) ? required(value) : true
+          },
           url (value) {
             return url(value)
           }

From 8abb06085963356bbdee742c889e66d386f16860 Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 20:57:15 +0100
Subject: [PATCH 10/12] feat: show bridgechain asset repository in bridgechain
 details

---
 .../WalletBusinessShowBridgechain.vue         | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/src/renderer/components/Wallet/WalletBusiness/WalletBusinessShowBridgechain.vue b/src/renderer/components/Wallet/WalletBusiness/WalletBusinessShowBridgechain.vue
index ad29f09bfb..ade0d34416 100644
--- a/src/renderer/components/Wallet/WalletBusiness/WalletBusinessShowBridgechain.vue
+++ b/src/renderer/components/Wallet/WalletBusiness/WalletBusinessShowBridgechain.vue
@@ -68,6 +68,35 @@
         </a>
       </ListDividedItem>
 
+      <ListDividedItem
+        v-if="bridgechain.bridgechainAssetRepository"
+        :label="$t('WALLET_BUSINESS.BRIDGECHAIN.BRIDGECHAIN_ASSET_REPOSITORY')"
+        class="WalletBusinessShowBridgechain__bridgechain-asset-repo"
+      >
+        <a
+          class="flex items-center whitespace-no-wrap"
+          href="#"
+          @click.stop="electron_openExternal(bridgechain.bridgechainAssetRepository)"
+        >
+          <span
+            v-tooltip="{
+              content: bridgechain.bridgechainAssetRepository,
+              classes: 'text-xs',
+              trigger: 'hover'
+            }"
+            class="WalletBusinessShowBridgechain__bridgechain-asset-repo__item mr-1"
+          >
+            {{ bridgechain.bridgechainAssetRepository }}
+          </span>
+
+          <SvgIcon
+            name="open-external"
+            view-box="0 0 12 12"
+            class="text-theme-page-text-light"
+          />
+        </a>
+      </ListDividedItem>
+
       <ListDividedItem
         :label="$t('WALLET_BUSINESS.BRIDGECHAIN.API_PORT')"
         :value="bridgechain.ports['@arkecosystem/core-api']"

From dce3c4cab7fc57e90355113f70a6d51c59ee41ac Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 21:10:40 +0100
Subject: [PATCH 11/12] test: adjust unit tests

---
 .../TransactionFormBusiness/mixin.spec.js     | 34 +++++++++++--------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
index 618166ec85..2d2ecfb0ac 100644
--- a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
+++ b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBusiness/mixin.spec.js
@@ -350,20 +350,24 @@ describe.each([
       })
 
       it('should return null if not dirty', () => {
-        wrapper.vm.$v.form.asset.vat.$model = ''
-        wrapper.vm.$v.form.asset.vat.$reset()
+        if (componentName === 'TransactionFormBusinessRegistration') {
+          wrapper.vm.$v.form.asset.vat.$model = ''
+          wrapper.vm.$v.form.asset.vat.$reset()
 
-        expect(wrapper.vm.$v.form.asset.vat.$dirty).toBe(false)
-        expect(wrapper.vm.$v.form.asset.vat.$invalid).toBe(false)
-        expect(wrapper.vm.vatError).toBe(null)
+          expect(wrapper.vm.$v.form.asset.vat.$dirty).toBe(false)
+          expect(wrapper.vm.$v.form.asset.vat.$invalid).toBe(false)
+          expect(wrapper.vm.vatError).toBe(null)
+        }
       })
 
       it('should return null if empty as not required', () => {
-        wrapper.vm.$v.form.asset.vat.$model = ''
+        if (componentName === 'TransactionFormBusinessRegistration') {
+          wrapper.vm.$v.form.asset.vat.$model = ''
 
-        expect(wrapper.vm.$v.form.asset.vat.$dirty).toBe(true)
-        expect(wrapper.vm.$v.form.asset.vat.$invalid).toBe(false)
-        expect(wrapper.vm.vatError).toBe(null)
+          expect(wrapper.vm.$v.form.asset.vat.$dirty).toBe(true)
+          expect(wrapper.vm.$v.form.asset.vat.$invalid).toBe(false)
+          expect(wrapper.vm.vatError).toBe(null)
+        }
       })
 
       it('should not return error if shorter than max (15)', () => {
@@ -439,12 +443,14 @@ describe.each([
       })
 
       it('should return null if not dirty', () => {
-        wrapper.vm.$v.form.asset.repository.$model = ''
-        wrapper.vm.$v.form.asset.repository.$reset()
+        if (componentName === 'TransactionFormBusinessRegistration') {
+          wrapper.vm.$v.form.asset.repository.$model = ''
+          wrapper.vm.$v.form.asset.repository.$reset()
 
-        expect(wrapper.vm.$v.form.asset.repository.$dirty).toBe(false)
-        expect(wrapper.vm.$v.form.asset.repository.$invalid).toBe(false)
-        expect(wrapper.vm.repositoryError).toBe(null)
+          expect(wrapper.vm.$v.form.asset.repository.$dirty).toBe(false)
+          expect(wrapper.vm.$v.form.asset.repository.$invalid).toBe(false)
+          expect(wrapper.vm.repositoryError).toBe(null)
+        }
       })
 
       it('should not return error if longer than min (12)', () => {

From 271039c382eff0f09f144c05e4c052ceba9f498c Mon Sep 17 00:00:00 2001
From: Edgar Goetzendorff <hello@dated.fun>
Date: Tue, 3 Mar 2020 21:22:43 +0100
Subject: [PATCH 12/12] test: adjust unit tests

---
 .../TransactionFormBridgechain/mixin.spec.js   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.spec.js b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.spec.js
index 6103956174..0623aedfd7 100644
--- a/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.spec.js
+++ b/__tests__/unit/components/Transaction/TransactionForm/TransactionFormBridgechain/mixin.spec.js
@@ -774,17 +774,17 @@ describe.each([
         expect(wrapper.vm.bridgechainAssetRepositoryError).toBe(null)
       })
 
-      it('should return null if not dirty', () => {
-        wrapper.vm.$v.form.asset.bridgechainAssetRepository.$model = ''
-        wrapper.vm.$v.form.asset.bridgechainAssetRepository.$reset()
-
-        expect(wrapper.vm.$v.form.asset.bridgechainAssetRepository.$dirty).toBe(false)
-        expect(wrapper.vm.$v.form.asset.bridgechainAssetRepository.$invalid).toBe(false)
-        expect(wrapper.vm.bridgechainAssetRepositoryError).toBe(null)
-      })
-
       if (componentName === 'TransactionFormBridgechainRegistration') {
         describe('TransactionFormBridgechainRegistration', () => {
+          it('should return null if not dirty', () => {
+            wrapper.vm.$v.form.asset.bridgechainAssetRepository.$model = ''
+            wrapper.vm.$v.form.asset.bridgechainAssetRepository.$reset()
+
+            expect(wrapper.vm.$v.form.asset.bridgechainAssetRepository.$dirty).toBe(false)
+            expect(wrapper.vm.$v.form.asset.bridgechainAssetRepository.$invalid).toBe(false)
+            expect(wrapper.vm.bridgechainAssetRepositoryError).toBe(null)
+          })
+
           it('should not return error if valid', () => {
             wrapper.vm.$v.form.asset.bridgechainAssetRepository.$model = 'https://github.com/arkecosystem/desktop-wallet.git'