Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pricing api with @arkecosystem/platform-sdk #1786

Merged
merged 3 commits into from Mar 9, 2020

Conversation

@faustbrian
Copy link
Contributor

faustbrian commented Mar 6, 2020

Replaces the pricing APIs with ones from https://github.com/ArkEcosystem/platform-sdk which will be used to share things across our applications. Also removes a bunch of methods that I couldn't find any reference of usage for.

@faustbrian faustbrian force-pushed the psdk-pricing branch from 8790b60 to fb5ab07 Mar 6, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2020

Codecov Report

No coverage uploaded for pull request base (develop@dc46646). Click here to learn what that means.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1786   +/-   ##
==========================================
  Coverage           ?   59.42%           
==========================================
  Files              ?      363           
  Lines              ?     9025           
  Branches           ?     1831           
==========================================
  Hits               ?     5363           
  Misses             ?     3480           
  Partials           ?      182
Impacted Files Coverage Δ
...rc/renderer/components/MarketChart/MarketChart.vue 31.85% <0%> (ø)
src/renderer/store/modules/market.js 4.34% <0%> (ø)
src/renderer/components/Network/NetworkModal.vue 47.9% <100%> (ø)
src/renderer/services/price-api.ts 53.12% <53.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc46646...20a7d05. Read the comment docs.

wip
@faustbrian faustbrian merged commit b8e7672 into develop Mar 9, 2020
0 of 2 checks passed
0 of 2 checks passed
eslint eslint
Details
lint-unit (12.x) lint-unit (12.x)
Details
@faustbrian faustbrian deleted the psdk-pricing branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.