Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add singleAction variant to wallet list item component #2157

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jun 16, 2020

Summary

Adds a variant prop to the WalletListItem component which if set to singleAction will display a button instead of the dropdown.

Also allows to not render the table cell for the wallet type icons by setting the walletTypeIcons prop to null.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner June 16, 2020 23:14
@ghost
Copy link

ghost commented Jun 16, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #2157 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2157    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             24        98    +74     
  Lines            142       760   +618     
  Branches          18       118   +100     
============================================
+ Hits             142       760   +618     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20ec3a...e90eec4. Read the comment docs.

@faustbrian faustbrian merged commit d829c07 into 3.0-react Jun 17, 2020
@faustbrian faustbrian deleted the feat/wallet-list-item-single-action branch June 17, 2020 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants