Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement search in MyRegistrations #2805

Merged
merged 11 commits into from Sep 11, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Sep 7, 2020

Summary

Depends on #2804

Implement local search functionality on Delegates , Business and Plugin lists.

  • Search delegates by delegate username
  • Search entities by wallet name, wallet address, asset name (Business & Plugin name)
  • Add Search Empty result screen (similar to News page)
  • Reset search functionality

Example of found result:
2020-09-07-195526_1049x545_scrot

Example of empty search result:
2020-09-07-200025_1259x826_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Sep 7, 2020
@goga-m goga-m changed the title feat: implement search functionality in MyRegistrations feat: implement search in MyRegistrations Sep 7, 2020
@faustbrian
Copy link
Contributor

Task linked: CU-7ytaze Search functionality

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2805 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2805     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       320    +296     
  Lines            142      4220   +4078     
  Branches          18       758    +740     
=============================================
+ Hits             142      4220   +4078     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 340 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2f09c...5bb4fa6. Read the comment docs.

Copy link
Contributor

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes on this PR for when a search is performed in a profile that contains 0 registrations.

Copy link
Contributor

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes implemented

@faustbrian faustbrian merged commit 087ffc4 into 3.0-react Sep 11, 2020
@ghost ghost deleted the feat/search-registrations branch September 11, 2020 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants