Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: use NetworkIcon in wallet card and list #2836

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 17, 2020

Summary

Updates the WalletCard and WalletListItem components to use the NetworkIcon component and removes obsolete properties.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2836 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2836     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       325    +301     
  Lines            142      4368   +4226     
  Branches          18       800    +782     
=============================================
+ Hits             142      4368   +4226     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 344 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd85b5...c55f8f4. Read the comment docs.

@faustbrian faustbrian merged commit 5bca638 into 3.0-react Sep 17, 2020
@ghost ghost deleted the refactor/wallet-icons branch September 17, 2020 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants