Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: close modal with ESC key #2907

Merged
merged 2 commits into from
Oct 2, 2020
Merged

feat: close modal with ESC key #2907

merged 2 commits into from
Oct 2, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Oct 1, 2020

Summary

Task: https://app.clickup.com/t/296a7y

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2907 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2907   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          349       349           
  Lines         4889      4896    +7     
  Branches       901       902    +1     
=========================================
+ Hits          4889      4896    +7     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Modal/Modal.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2488493...99b3942. Read the comment docs.

@faustbrian faustbrian merged commit 1a5f6b7 into develop Oct 2, 2020
@ghost ghost deleted the feat/modal-esc-key branch October 2, 2020 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants