New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filters amountToCurrency and formatCurrency #426

Merged
merged 3 commits into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@ckhatri
Contributor

ckhatri commented Nov 21, 2017

Noticed in some places that we weren't utilizing the filters when possible, went ahead and fixed it in a few html files.

@j-a-m-l j-a-m-l self-requested a review Nov 22, 2017

@j-a-m-l

j-a-m-l requested changes Nov 23, 2017 edited

I've found a problem on the offchain tab:

duplicated-currency

@ckhatri

This comment has been minimized.

Show comment
Hide comment
@ckhatri

ckhatri Nov 23, 2017

Contributor

Fixed! Sorry about that. Using the filter already adds the symbol so I had to take the hardcoded symbol out.

Contributor

ckhatri commented Nov 23, 2017

Fixed! Sorry about that. Using the filter already adds the symbol so I had to take the hardcoded symbol out.

@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Nov 30, 2017

Member

Looks good to me!

+5 👌

Member

alexbarnsley commented Nov 30, 2017

Looks good to me!

+5 👌

@alexbarnsley alexbarnsley merged commit 87a9628 into ArkEcosystem:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ckhatri ckhatri deleted the ckhatri:usefilters_inoffchain branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment