New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation to warn user of the cost of second passphrase #435

Merged
merged 8 commits into from Dec 16, 2017

Conversation

Projects
None yet
2 participants
@ckhatri
Contributor

ckhatri commented Dec 4, 2017

Some people on the subreddit were mentioning there wasn't any popup or information about how creating a second passphrase costs ark. This toast warning message should popup and warn them how much it'll cost!

@j-a-m-l j-a-m-l assigned j-a-m-l and unassigned j-a-m-l Dec 4, 2017

@j-a-m-l j-a-m-l self-requested a review Dec 4, 2017

@j-a-m-l

I like the idea, but some people may ignore the notice message, so probably the best way to avoid that is:

  • Change the text, to reflect that it's necessary to back-up the passphrase AND pay n ARK.
  • Show a confirmation after clicking NEXT that informs that it's necessary to back-up the passphrase and pay n ARK.
Show outdated Hide outdated client/app/config/config.js
Show outdated Hide outdated client/app/config/config.js

@j-a-m-l j-a-m-l changed the title from added toast message to warn user of second passphrase to Add confirmation to warn user of the cost of second passphrase Dec 16, 2017

@j-a-m-l j-a-m-l merged commit 115c53f into ArkEcosystem:master Dec 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Dec 16, 2017

Member

+5 Good work!

Member

j-a-m-l commented Dec 16, 2017

+5 Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment