New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic empty state component #445

Merged
merged 3 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@perryhoffman
Contributor

perryhoffman commented Dec 9, 2017

Adding a small empty state component to enhance the user experience for users who have/create new accounts. The component is implemented across all of the tabs. It hopefully adds some UI consistency to tabs that don't currently have information to display (like the exchange 'Coming soon' message).

An example on the transactions tab:

screen shot 2017-12-08 at 6 30 23 pm

Still familiarizing myself with this project, all feedback is welcomed! 馃槃

@j-a-m-l j-a-m-l self-requested a review Dec 9, 2017

@j-a-m-l

Elegant solution but could you change the text to an impersonal style (these tabs are used on the contacts too)?

Fixing language to reflect empty states for contact accounts. Hiding 鈥
鈥mpty state for the offchain tab when viewing a contact account without ownership.
@perryhoffman

This comment has been minimized.

Show comment
Hide comment
@perryhoffman

perryhoffman Dec 9, 2017

Contributor

Good catch @j-a-m-l , I have updated the language accordingly.

Contributor

perryhoffman commented Dec 9, 2017

Good catch @j-a-m-l , I have updated the language accordingly.

@j-a-m-l j-a-m-l merged commit 010ee20 into ArkEcosystem:master Dec 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Dec 11, 2017

Member

Good work! +5

Member

j-a-m-l commented Dec 11, 2017

Good work! +5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment