New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to QR Code on Dark Theme #446

Merged
merged 1 commit into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@Wolvan
Contributor

Wolvan commented Dec 9, 2017

While trying to scan the QR Code of my wallet address in the wallet, the
dark theme ended up being problematic as my phone was unable to find the
borders of the QR Code. The dark theme's QR Code should have a white
border around it to counteract this problem with scanning when using
dark theme.

I opted for an 8px border and added an element offset margin so it stays
in the place it is supposed to be.

Add border to QR Code on Dark Theme
While trying to scan the QR Code of my wallet address in the wallet, the
dark theme ended up being problematic as my phone was unable to find the
borders of the QR Code. The dark theme's QR Code should have a white
border around it to counteract this problem with scanning when using
dark theme.

I opted for an 8px border and added an element offset margin so it stays
in the place it is supposed to be.

@j-a-m-l j-a-m-l self-requested a review Dec 9, 2017

@j-a-m-l

j-a-m-l approved these changes Dec 9, 2017

@j-a-m-l j-a-m-l merged commit f025f72 into ArkEcosystem:master Dec 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Dec 9, 2017

Member

Good work! +5

Member

j-a-m-l commented Dec 9, 2017

Good work! +5

@boldninja

This comment has been minimized.

Show comment
Hide comment
@boldninja

boldninja Jan 2, 2018

Member

@Wolvan can you contact me on Slack or post your ARK address here for Github bounty?

Member

boldninja commented Jan 2, 2018

@Wolvan can you contact me on Slack or post your ARK address here for Github bounty?

@Wolvan

This comment has been minimized.

Show comment
Hide comment
@Wolvan

Wolvan Jan 3, 2018

Contributor

AMtXb2ZPxHYFUhB4WBRfUAt21opkEuvC8p here you go! Thanks a lot for accepting this PR!

Contributor

Wolvan commented Jan 3, 2018

AMtXb2ZPxHYFUhB4WBRfUAt21opkEuvC8p here you go! Thanks a lot for accepting this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment