New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ark values in transaction tab selectable #448

Merged
merged 2 commits into from Dec 14, 2017

Conversation

Projects
None yet
2 participants
@Nasicus
Contributor

Nasicus commented Dec 10, 2017

I noticed that the actual Ark values (total) are not selectable because they are "disabled buttons".
This really bugged me since all other values in this table are selectable and the value is in my opinion one of the most important things and should definitely be selectable.

So what I did the following:
Changed them all to span's, gave them the button style and removed (with a second class) the styles which made the text not selectable.

The before and after look was the exact same for me :)

image

Let me know what you think!
Note that this is my first commit here and I'm not sure if my apporach is good :)

BTW: There may be other places in code where this should be done, but I thought before I look for them I wanted to get feedback on this.

@j-a-m-l j-a-m-l self-requested a review Dec 11, 2017

@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Dec 11, 2017

Member

I think that you approach is correct :) . You can continue with the other places.

Member

j-a-m-l commented Dec 11, 2017

I think that you approach is correct :) . You can continue with the other places.

@Nasicus

This comment has been minimized.

Show comment
Hide comment
@Nasicus

Nasicus Dec 11, 2017

Contributor

Thanks.

I searched for all occurrences of md-button but did not find any other place where this should be required.

The only place which may be in question is here:
image

However I personally don't think it's necessary, especially since there are actions on the "folder name" if you click.

Contributor

Nasicus commented Dec 11, 2017

Thanks.

I searched for all occurrences of md-button but did not find any other place where this should be required.

The only place which may be in question is here:
image

However I personally don't think it's necessary, especially since there are actions on the "folder name" if you click.

@j-a-m-l

That button should be changed, so the amount would be selectable too.

@Nasicus

This comment has been minimized.

Show comment
Hide comment
@Nasicus

Nasicus Dec 12, 2017

Contributor

Done 👍

Contributor

Nasicus commented Dec 12, 2017

Done 👍

@j-a-m-l j-a-m-l merged commit 894c5f2 into ArkEcosystem:master Dec 14, 2017

@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Dec 14, 2017

Member

+5 thanks

Member

j-a-m-l commented Dec 14, 2017

+5 thanks

@Nasicus Nasicus deleted the Nasicus:feat/selectable-ark-values branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment