New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that qr scanner doesn't work correctly for 'To' field #456

Merged
merged 2 commits into from Dec 27, 2017

Conversation

Projects
None yet
2 participants
@Nasicus
Contributor

Nasicus commented Dec 13, 2017

Problem was that ng-model is not supported on md-autocomplete.

To work around this we have to set the selectAddress property which is used on the md-autocomplete. However we cannot really set the field directly from the qr scanner directive (because it a "contact").

My solution was to introduce a callback-function parameter (which I personally find nicer anyway, instead of having to relay on, that the object path send.data exists).

Please note that I'm not very good with angular 1 - and it may very be possible that there is a better fix for this. I'm always open for feedback :)

fixes: #454

@@ -63,7 +69,8 @@
onSuccess: '&',
onError: '&',
onVideoError: '&',
inputCallback: '@'
inputCallback: '@',
inputCallbackFunc: '&'

This comment has been minimized.

@alexbarnsley

alexbarnsley Dec 27, 2017

Member

From what I can tell, this isn't used. Is that correct @Nasicus

Edit: Sorry, I mean in relation to the element. Is inputCallbackFunc ever called?

@alexbarnsley

alexbarnsley Dec 27, 2017

Member

From what I can tell, this isn't used. Is that correct @Nasicus

Edit: Sorry, I mean in relation to the element. Is inputCallbackFunc ever called?

This comment has been minimized.

@Nasicus

Nasicus Dec 27, 2017

Contributor

This comment has been minimized.

@alexbarnsley

alexbarnsley Dec 27, 2017

Member

My apologies, I was being thick! 👌

@alexbarnsley

alexbarnsley Dec 27, 2017

Member

My apologies, I was being thick! 👌

@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Dec 27, 2017

Member

Just 1 question/comment really. Tested and it's working 👍

Member

alexbarnsley commented Dec 27, 2017

Just 1 question/comment really. Tested and it's working 👍

@alexbarnsley alexbarnsley merged commit d76aa48 into ArkEcosystem:master Dec 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Dec 27, 2017

Member

Nice work! +5! 👍

Member

alexbarnsley commented Dec 27, 2017

Nice work! +5! 👍

@Nasicus Nasicus deleted the Nasicus:bug/qr-code-to-address/454 branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment