New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes couldn't set selectedTextBackgroundColor #466

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Projects
None yet
3 participants
@ckhatri
Contributor

ckhatri commented Dec 17, 2017

Very small change, not necessary at all, but it was bothering me to have that error, so I decided to fix it.

Fixes Electron Helper[14028:538660] Couldn't set selectedTextBackgroundColor from default ()
error that you get at startup

@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Dec 27, 2017

Member

@ckhatri how do i recreate this issue? I'm not able to see the Helper message you're referring to.

Edit: From what i can tell, this message only shows up when i open the devtools. Is that correct?

Member

alexbarnsley commented Dec 27, 2017

@ckhatri how do i recreate this issue? I'm not able to see the Helper message you're referring to.

Edit: From what i can tell, this message only shows up when i open the devtools. Is that correct?

@luciorubeens

This comment has been minimized.

Show comment
Hide comment
@luciorubeens

luciorubeens Dec 27, 2017

Member

@alexbarnsley true, this is displayed in the terminal
but the message still appears with this PR

Member

luciorubeens commented Dec 27, 2017

@alexbarnsley true, this is displayed in the terminal
but the message still appears with this PR

@ckhatri

This comment has been minimized.

Show comment
Hide comment
@ckhatri

ckhatri Dec 27, 2017

Contributor

I was getting this bug whenever I highlighted something for the first time in the app. So I would just do npm start -> highlight the price. When I was testing I didn't try opening up dev-tools. So it seems like that still causes the issue, I'll look into seeing if there's a fix for that! But if you try to highlight something in the app that parts fixed.

Don't think its possible to fix it for the dev-tools issue since this is a chromium bug.

https://bugs.chromium.org/p/chromium/issues/detail?id=641509

Contributor

ckhatri commented Dec 27, 2017

I was getting this bug whenever I highlighted something for the first time in the app. So I would just do npm start -> highlight the price. When I was testing I didn't try opening up dev-tools. So it seems like that still causes the issue, I'll look into seeing if there's a fix for that! But if you try to highlight something in the app that parts fixed.

Don't think its possible to fix it for the dev-tools issue since this is a chromium bug.

https://bugs.chromium.org/p/chromium/issues/detail?id=641509

@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Dec 28, 2017

Member

Hm I never get that issue. Would you mind doing a screen recording so I can see your steps / see if resolved? I'm happy to ignore the chromium bug

Member

alexbarnsley commented Dec 28, 2017

Hm I never get that issue. Would you mind doing a screen recording so I can see your steps / see if resolved? I'm happy to ignore the chromium bug

@ckhatri

This comment has been minimized.

Show comment
Hide comment
@ckhatri
Contributor

ckhatri commented Dec 28, 2017

@alexbarnsley

This comment has been minimized.

Show comment
Hide comment
@alexbarnsley

alexbarnsley Dec 29, 2017

Member

Seems to have fixed message on console for reload for me too.

Nice +5 👍

Member

alexbarnsley commented Dec 29, 2017

Seems to have fixed message on console for reload for me too.

Nice +5 👍

@alexbarnsley alexbarnsley merged commit db00f3a into ArkEcosystem:master Dec 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ckhatri ckhatri deleted the ckhatri:fixSelectedTeextBackground branch Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment