Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Unify passphrase input in the whole app #482
While doing "a little" testing for my other PR I saw that the input (password) field of the passphrases is different depending on where you are:
Also the same code was duplicated throughout the solution.
I extracted the logic into an own component and used this in the whole app.
While doing that I one question came up:
While doing the refactor I also detected 2 anonmalies which may or may not be bugs:
I tested ALL actions where I replaced this field on the DARKNET.
Yeah, we only need the original passphrase to sign messages. The second passphrase is used to sign transactions, it's useful to the owner of the wallet because it is an extra layer of security.