Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Get all transactions when exporting account #485
I implemented it so that it always gets 50 transactions per call (which I think is the max?).
Note that this takes VERY long on big accounts!
I tried this for Jarunik:
I'm not sure if we should now show a selection to the user of how many transactions he wants to export (eg. 50, 100, 500, 1000, All) or even a selection for which time span the transaction should be exported (but I don't think the API offers this possibility yet? )
Well let me know what you guys think :)
I wasn't satisfied with what I did.
So I implemented the dialog where the user can choose how many transactions to export.
I do think the date range would be the better approach. Since transactions are ordered pretty much in date order, you could keep getting pages (like you are at the minute) until you reach a specific date. I know it's a bit more of an intensive task, but that way you can guarantee exporting gives you all the transactions you need
When reviewing please pay special attention to:
I wrote unit tests for both of these methods, however it would still be good if someone else could verify the logic of them!
Some screenshot on how it looks now:
Edit: fixed typo in screenshot
I think that is necessary to notify the user that the process has finished:
I've exported an account and my impression, as a normal user, is that, since I don't see any message, the process could have failed silently. Adding a message with a "OK" button or similar would be enough, probably.
One small bug (from the previous work), is that the balance isn't correct:
9900000000 instead of
Very good job, anyway.
Awesome job, but some additional changes:
- Add a cancel button or a way to dismiss the last modal instead of being force to download it.
- Instead of exporting the
smartbridgeas undefined, keep it empty.
I haven't been able to reproduce the date-selector problem.
I moved the button to the button row and I remebered that I can use