Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Delegate Vote Refactor #491
I have been meaning to make this PR for a while now! It's been tricky with the busy holiday season. There is still a lot of room for improvement on this, but with the ARK community getting larger by the day I feel like the changes are a necessary step in the right direction. The issue is regarding the current state of delegate voting, and the confusion surrounding the user experience. Various issues I have seen include this Reddit Post, the UI changes referred to in #346, and a few others.
The changes to the UI are as follows:
A tooltip has been added to the disabled Vote button if there is an active delegate explaining only 1 delegate can be active at a time. There was also a bug with the theme of the vote dialog template that was fixed. I also refactored the logic surrounding the vote/unvote methods out of the main account.controller in the process.
Some help testing this and feedback on this is welcomed! Shoutout to @heyhaigh on slack for the consulting
Looks very promising. Removing the confusion that generates having both "Add delegate" and "Vote" buttons is a very good idea.
Since this is very related to the purpose of this PR, would you mind to check #479. Adding a link would suffice probably.