Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Validate passphrase when importing account #498
People all the time mistyped their passphrase when importing account and then panic when see an empty wallet. This PR should fix this:
referenced this pull request
Jan 5, 2018
Good work, but I'll suggest 1 change:
Instead of "custom passphrase" I'd use something different because users could have problems understanding that is "custom" in this context.
Maybe something like "Permit non-BIP39 passphrases" would be descriptive enough.
What do you think?
Yes, @zillionn a lot of users don't know what it is, but that text include something that is less ambiguous than "custom". In fact, they would have a way to learn about passphrases, which is something unexpected for a lot of people that are used to choosing their own passwords.
Other idea: "Use a custom (non-BIP39) passphrase", where "BIP39" links to https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki