New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it possible to input small numbers into the input field #652

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@ItsANameToo
Collaborator

ItsANameToo commented Dec 4, 2018

Proposed changes

You couldn't input 0.0000001 as it would be turned into 1e-7:

schermafbeelding 2018-12-04 om 20 26 58

Now it's fixed and possible to input the correct amount:

schermafbeelding 2018-12-04 om 21 01 43

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@zillionn

This comment has been minimized.

Contributor

zillionn commented Dec 4, 2018

You could also restrict it to only positive numbers, because if balance is 0 and click Send All it shows -txfee.

@ItsANameToo

This comment has been minimized.

Collaborator

ItsANameToo commented Dec 4, 2018

Good point, will probably do that in a separate PR tho

@j-a-m-l

This comment has been minimized.

Member

j-a-m-l commented Dec 4, 2018

Wouldn't it be better doing both things here? 🤔 To avoid checking the same thing 2 times

@ItsANameToo

This comment has been minimized.

Collaborator

ItsANameToo commented Dec 4, 2018

No, I get paid per PR for bounties and I don't think that change has to do with this PR as it would probably be a check on the switch and nothing to do with populating the value of the input field

@j-a-m-l

This comment has been minimized.

Member

j-a-m-l commented Dec 4, 2018

OK then.

@faustbrian faustbrian merged commit 95b5af8 into develop Dec 5, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/small-number-input branch Dec 5, 2018

PHANTOM-DEV1 pushed a commit to PhantomChain/desktop-wallet that referenced this pull request Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment