New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to remove the set name of a wallet #653

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@ItsANameToo
Collaborator

ItsANameToo commented Dec 4, 2018

Proposed changes

It wasn't possible to remove the name of a wallet, as you would get an error saying that '' was already taken as a wallet name. This PR makes it possible to rename a wallet to '' again so it reverts to the original address (or delegate / contact name).

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l self-requested a review Dec 4, 2018

@j-a-m-l

This comment has been minimized.

Member

j-a-m-l commented Dec 4, 2018

@ItsANameToo where is it failing? I've created a wallet with a name and I can rename it to "" (empty).

@ItsANameToo

This comment has been minimized.

Collaborator

ItsANameToo commented Dec 4, 2018

Add a wallet without a name, that one will be stored as '', then add another wallet with a name, then try to rename that second wallet to one without name and it will fail as there is already a wallet with '' available in the store.

@faustbrian faustbrian merged commit a3f05ae into develop Dec 5, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the feat/remove-wallet-name branch Dec 5, 2018

PHANTOM-DEV1 pushed a commit to PhantomChain/desktop-wallet that referenced this pull request Dec 6, 2018

feat: more detail in transaction toasts (ArkEcosystem#653)
* feat: more detail in transaction toasts

* chore: remove word from translation

* test: fix failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment