New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get ledger wallet first from route #661

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@alexbarnsley
Member

alexbarnsley commented Dec 5, 2018

Proposed changes

This fixes an issue where it checked for a ledger wallet only if the local database didn't have a record. This caused issues if the ledger wallet was added as a contact, for example. Meaning when a ledger wallet was plugged in and viewed, the wallet thought it was a contact, resulting in the inability to send transactions.

Resolves #634

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 5ea7f14 into develop Dec 5, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/ledger-send-button branch Dec 5, 2018

PHANTOM-DEV1 pushed a commit to PhantomChain/desktop-wallet that referenced this pull request Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment