Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ui: hide secondary action buttons where applicable & misc ui tweaks #757

Merged
merged 11 commits into from Dec 16, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 14, 2018

Proposed changes

Icon not centered in peer reload button

image

Ark logo is not squared, looks funky

imageimage

The arrows of the settings and network popups are misplaced (yellow)

imageimage

The drop down arrow isn't centered

image

Icon not centered in clipboard button

image

To narrow spacing between identicon and text in sign/verify tab

image

Bottom border on last transaction table row

image

Icon not centered in passphrase reload button

image

The Save transaction button is off center

image

This PR also hides the delegate registration and 2nd passphrase buttons if the wallet is already registered or has a 2nd passphrase already.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Other... Please describe: UI

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated added some commits Dec 14, 2018

@dated dated changed the title [WIP] misc: ui tweaks refactor/ui: hide secondary action buttons where applicable & misc ui tweaks Dec 15, 2018

dated and others added some commits Dec 15, 2018

@faustbrian faustbrian merged commit 56eb8f7 into ArkEcosystem:develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:ui-tweaks branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.