Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show contacts in sidebar if wallet is contact #758

Merged
merged 2 commits into from Dec 16, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 15, 2018

Proposed changes

When you opened a contact, it would only show wallets in the sidebar and when changing to one it would not show the additional tabs that a wallet has. This PR changes the sidebar to show contacts when the wallet is a contact, and wallets when it's a wallet. This indirectly fixes #756

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

ItsANameToo and others added some commits Dec 15, 2018

@faustbrian faustbrian merged commit 4b663d7 into develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/wallet-sidebar branch Dec 16, 2018

zillionn pushed a commit to zillionn/desktop-wallet that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.