Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reset heading on wallet change #759

Merged
merged 2 commits into from Dec 16, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 15, 2018

Proposed changes

Imho the wallet heading should be reset to the default state when switching wallets, i.e. when currently the secondary action buttons are shown, switching wallets should cause the wallet to show the wallet info and primary action buttons.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated and others added some commits Dec 15, 2018

@faustbrian faustbrian merged commit aa79b41 into ArkEcosystem:develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:reset-heading branch Dec 16, 2018

zillionn pushed a commit to zillionn/desktop-wallet that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.