Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include fee in second signature builder #766

Merged
merged 3 commits into from Dec 16, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 15, 2018

Proposed changes

The fee was not being added to the transaction in buildSecondSignatureRegistration. Fixes #764.

Also replaces occurrences of Math.pow(10, 8) and Math.pow(10, -8) with the the respective e notation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated and others added some commits Dec 15, 2018

@faustbrian faustbrian merged commit d423f7a into ArkEcosystem:develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ItsANameToo ItsANameToo referenced this pull request Dec 16, 2018

zillionn pushed a commit to zillionn/desktop-wallet that referenced this pull request Dec 19, 2018

@dated dated deleted the dated:2nd-signature-fee branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.