Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Next disabled when backing from sending 2nd passphrase registration #768

Merged
merged 3 commits into from Dec 17, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 15, 2018

#765

Proposed changes

When passphrase is verified and submitted, it currently resets many data props (including this.isPassphraseVerified = false). This is only set to true when the <PassphraseVerification> emits @verified, which can't happen more than once: when the last word is verified.
https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/components/Passphrase/PassphraseVerification.vue#L149

Proposed change is simply to set this.isPassphraseVerified = true when in the if (success) branch of the submit() method, last before the sending confirmation screen. This has no breaking effect, because the random mnemonic is only generated once per modal.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

JeremiGendron and others added some commits Dec 15, 2018

@j-a-m-l j-a-m-l self-requested a review Dec 17, 2018

@j-a-m-l j-a-m-l merged commit bcda188 into ArkEcosystem:develop Dec 17, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@JeremiGendron JeremiGendron deleted the JeremiGendron:fix/2nd-passphrase-next-disabled branch Dec 17, 2018

zillionn pushed a commit to zillionn/desktop-wallet that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.