Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only reset buttons when the curretWallet has changed #771

Merged
merged 2 commits into from Dec 16, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 16, 2018

Proposed changes

#759 introduced resetting the wallet buttons when the wallet was changed, but this was done by watching the currentWallet property for changes. This property "changes" every x seconds due to refreshing, which would result in buttons being reset while the wallet itself did not change. As a sideeffect, this would also close the second signature or delegate registration modals if those were open, making it difficult to work with those transaction type. This PR adds a check to only reset the buttons when the wallet actually changed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

ItsANameToo and others added some commits Dec 16, 2018

@faustbrian faustbrian merged commit 75e92bb into develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/wallet-button-reset branch Dec 16, 2018

@JeremiGendron JeremiGendron referenced this pull request Dec 17, 2018
4 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.