Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve validation issues making it impossible to add a network #772

Merged
merged 2 commits into from Dec 16, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 16, 2018

Proposed changes

#680 introduced validation for adding a network, but that made it impossible to add a new network since all fields were checked in the validation (instead of the 3 that were on screen). This PR improves the validation rules so the rest of the fields are only checked when necessary.

Resolves #769

Also fixes an issue where the input would show a message that the value is required whenever the input field became dirty (even though there was a value in it). This has now been changed to only trigger if it's required + the input field is empty.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 0b41c2f into develop Dec 16, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/custom-network-validation branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.