Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: decompose korean characters so they match the generated ones for passphrases #779

Merged
merged 2 commits into from Dec 18, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 17, 2018

Proposed changes

When you set BIP39 to korean and then copy the passphrase it generates for you, it will import a different passphrase when you pasted and copied it from slack (or other editors that didn't keep the decomposed characters) . This is because the underlying passphrase uses the decomposed characters as opposed to the combined ones that are shown in the passphrase input (so if you would write them down on paper from the 12 inputs, you won't be able to import it)

Luckily there's something called normalize to fix this. I've tried it on English, Korean and Chinese and those all seem to work properly. Please test this thoroughly with the different phrases before importing. Now that I think of it, I'll add some tests for this too (so WIP)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (incoming)

@faustbrian faustbrian merged commit 7dfef47 into develop Dec 18, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/korean-passphrases branch Dec 18, 2018

@luciorubeens luciorubeens referenced this pull request Dec 18, 2018
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.