Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uninvuitive for jsonValidate() return value if (errors) #782

Merged
merged 4 commits into from Dec 18, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 18, 2018

Proposed changes

There's some errors which are hard to avoid efficiently with jsonValidate schema, for instance Delegate Registration has no recipient, but all transaction types are based off the TransactionModel, which has a strict schema where recipient is a string. Therefore, it might be acceptable to pretty-print the JSON schema used against the input, as well as the input itself.

I thought this might be a welcome change for debugging the schema.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit 38d86e1 into ArkEcosystem:develop Dec 18, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.