Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: normalizing passphrase with NFD option #786

Merged
merged 3 commits into from Dec 19, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 18, 2018

Proposed changes

Adds tests to show usage of NFD with passphrases. Also adds a comment in importWallet to indicate why it's used there

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

ItsANameToo and others added some commits Dec 18, 2018

@j-a-m-l j-a-m-l merged commit 6eb9f81 into develop Dec 19, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@j-a-m-l j-a-m-l deleted the test/normalizing branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.