Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove tooltip on ProfileAll #789

Merged
merged 2 commits into from Dec 19, 2018

Conversation

@kalgoop
Copy link
Contributor

commented Dec 19, 2018

tooltip on All profiles page was unnecessary and annoying. It doesn't help user in any way neither does it look good neither does it improve user experience.

Proposed changes

Remove :title of profile

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
Remove tooltip on ProfileAll
tooltip on All profiles page was unnecessary and annoying. It doesn't help user in any way neither does it look good neither does it improve user experience.
@luciorubeens

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

Thank you @kalgoop 👍🏻 and please read our Git Commit Guidelines.

@luciorubeens luciorubeens merged commit 3308245 into ArkEcosystem:develop Dec 19, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@kalgoop kalgoop changed the title Remove tooltip on ProfileAll refactor: remove tooltip on ProfileAll Dec 19, 2018

@kalgoop kalgoop deleted the kalgoop:patch-14 branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.