Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store only the id of the active wallet #790

Merged
merged 2 commits into from Dec 20, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 19, 2018

Proposed changes

As originally done in #780, storing the whole wallet object is unnecessary since only the ID is used for the comparison check. This also aligns with the same check introduced in #787.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated added some commits Dec 19, 2018

@luciorubeens luciorubeens merged commit 4b279ab into ArkEcosystem:develop Dec 20, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:active-wallet-id branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.