Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isPassphraseVerified on toggling ensureEntirePassphrase #792

Merged
merged 4 commits into from Dec 30, 2018

Conversation

@kalgoop
Copy link
Contributor

commented Dec 19, 2018

On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.

Proposed changes

On toggling ensureEntirePassphrase switch isPassphraseVerified is changed to false

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

kalgoop and others added some commits Dec 19, 2018

fix: isPassphraseVerified on toggling ensureEntirePassphrase
On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.

@faustbrian faustbrian merged commit 81ff756 into ArkEcosystem:develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix: isPassphraseVerified on toggling ensureEntirePassphrase (ArkEcos…
…ystem#792)

* fix: isPassphraseVerified on toggling ensureEntirePassphrase

On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.

* Update WalletNew.vue

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix: isPassphraseVerified on toggling ensureEntirePassphrase (ArkEcos…
…ystem#792)

* fix: isPassphraseVerified on toggling ensureEntirePassphrase

On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.

* Update WalletNew.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.