Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: isPassphraseVerified on toggling ensureEntirePassphrase #792

Merged
merged 4 commits into from Dec 30, 2018

Conversation

kalgoop
Copy link
Contributor

@kalgoop kalgoop commented Dec 19, 2018

On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.

Proposed changes

On toggling ensureEntirePassphrase switch isPassphraseVerified is changed to false

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

kalgoop and others added 2 commits December 19, 2018 17:05
On toggle of ensureEntirePassphrase on WalletNew Page, isPassphraseVerified remains true (after once verifying 3/all words)
This means user can press next w/ wrong passphrase.
@faustbrian faustbrian merged commit 81ff756 into ArkEcosystem:develop Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants