Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement address navigation directly in the wallet #793

Merged
merged 11 commits into from Dec 21, 2018

Conversation

@luciorubeens
Copy link
Member

commented Dec 19, 2018

Proposed changes

Implement the ability to open any address directly in the wallet.

Fixes #811

Types of changes

  • New feature (non-breaking change which adds functionality)
@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

👏

luciorubeens added some commits Dec 19, 2018

@luciorubeens luciorubeens changed the title [WIP] feat: implement address navigation directly in the wallet feat: implement address navigation directly in the wallet Dec 20, 2018

@dated dated referenced this pull request Dec 20, 2018
@j-a-m-l
Copy link
Contributor

left a comment

@luciorubeens good job, but some changes are required:

  • Disable the Sign tab when the wallet is not owned by the user
  • Disable the Purchase ARK tab or show the content (now is empty)
@luciorubeens

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

@j-a-m-l Did you run my last commit? I set up the wallet as a contact, so these tabs should not be displayed for contacts. https://github.com/ArkEcosystem/desktop-wallet/pull/793/files#diff-a4c65940a180037fae3ddcac8fcd6677R26

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

Yes, I've used the latest change on this branch (382b0d3). In contacts I don't see those empty tabs.

luciorubeens added some commits Dec 20, 2018

Merge branch 'feat/address-navigation' of github.com:ArkEcosystem/des…
…ktop-wallet into feat/address-navigation

@luciorubeens luciorubeens force-pushed the feat/address-navigation branch from 99863d8 to 027a403 Dec 20, 2018

@luciorubeens

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

@j-a-m-l Ok, it looks like the MenuTab component does not re-render when the slot is updated, then I called manually.

@j-a-m-l
Copy link
Contributor

left a comment

Now I've another problem:

  1. Go to the dashboard
  2. Click on a wallet on the last transactions that the user doesn't own.
  3. The wallets on the sidebar are incorrect (it shows contacts).
@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

@luciorubeens There is another problem that is not on the current develop branch: for some reason, hovering at addresses is making the tooltip blink furiously.

luciorubeens and others added some commits Dec 21, 2018

Merge branch 'feat/address-navigation' of github.com:ArkEcosystem/des…
…ktop-wallet into feat/address-navigation

@j-a-m-l j-a-m-l merged commit 95cbbf2 into develop Dec 21, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@j-a-m-l j-a-m-l deleted the feat/address-navigation branch Dec 21, 2018

@luciorubeens luciorubeens referenced this pull request Feb 25, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.