Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: truncate profile names #794

Merged
merged 8 commits into from Dec 30, 2018

Conversation

@kalgoop
Copy link
Contributor

commented Dec 19, 2018

Proposed changes

On walletAll page profile name truncated to 30
On ProfileAll page profile name truncated to 12

Types of changes

  • Other... Please describe: truncate profile names

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

kalgoop added some commits Dec 19, 2018

truncate profile name on ProfileAll
Profile name overflows the container, doesn't look good.
Like contact names, it should be truncated
truncate profileName on walletAll
truncate to 20 characters

kalgoop added some commits Dec 28, 2018

@kalgoop

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

@faustbrian faustbrian merged commit 2a2e4fd into ArkEcosystem:develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.