Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: market chart loader #796

Merged
merged 6 commits into from Dec 21, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 19, 2018

Proposed changes

Was a TODO: add loader to Market chart, it works when loading the tab initially and when switching between timespans or tabs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

JeremiGendron and others added some commits Dec 19, 2018

@j-a-m-l j-a-m-l self-requested a review Dec 20, 2018

@j-a-m-l
Copy link
Contributor

left a comment

Please, align the loader to be on the middle of the chart area.

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

sure

@JeremiGendron
Copy link
Contributor Author

left a comment

With a bit of postcss magic, everything has been solved.

@j-a-m-l
Copy link
Contributor

left a comment

It works perfectly, thanks.

I've added a comment with a small change.

src/renderer/components/MarketChart/MarketChart.vue Outdated Show resolved Hide resolved
@j-a-m-l
Copy link
Contributor

left a comment

Good job!

@j-a-m-l j-a-m-l merged commit f01c683 into ArkEcosystem:develop Dec 21, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.