Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display transfer sender options when used through `ark:` protocol #814

Merged
merged 22 commits into from Dec 21, 2018

Conversation

@alexbarnsley
Copy link
Member

commented Dec 20, 2018

Proposed changes

Dropdown on transfer form when using an ark: URI.

Todo:

  • Fix always loading URI on reload
  • Fix issue on "Next"
  • Fix sending whilst on a profile on a different network

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

alexbarnsley added some commits Dec 20, 2018

@alexbarnsley alexbarnsley changed the title [WIP] feat: transfer sender options feat: transfer sender options Dec 20, 2018

@j-a-m-l j-a-m-l changed the title feat: transfer sender options feat: display transfer sender options when used through `ark:` protocol Dec 21, 2018

@luciorubeens luciorubeens merged commit 5bfacca into develop Dec 21, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the feat/transfer-sender-options branch Dec 21, 2018

@alexbarnsley alexbarnsley referenced this pull request Dec 21, 2018
@zillionn

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

If I select a Mainnet profile and click on a Devnet link
ark:DT7quwHpfCCePpmhyf7MvyViCQ6KAVYr8c?amount=123&vendorField=test URI
this popup appears and the fields a disabled:

screenshot 2018-12-21 at 13 00 25

But only if Ledger is connected!

@boldninja

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

@zillionn new version with updated URI UI is on the way.

@zillionn

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

I'm testing develop branch with this merged PR.

@zillionn

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

@alexbarnsley alexbarnsley referenced this pull request Dec 21, 2018
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.