Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: add icons above create/import wallet #815

Merged
merged 9 commits into from Dec 21, 2018

Conversation

@zillionn
Copy link
Contributor

commented Dec 20, 2018

Proposed changes

Resolves #800

screenshot 2018-12-20 at 12 29 22

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

zillionn added some commits Dec 20, 2018

@j-a-m-l j-a-m-l self-requested a review Dec 20, 2018

@j-a-m-l
Copy link
Contributor

left a comment

Good work, but:

  • Add more margin to the top of the icons
  • To remove duplication, move those buttons to new components, called something like Wallet/WalletButton/WalletButtonCreate and Wallet/WalletButton/WalletButtonImport and adapt the WalletAll page to use this new components.
@zillionn

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

Done.

j-a-m-l and others added some commits Dec 20, 2018

@alexbarnsley alexbarnsley merged commit 25fbd4b into ArkEcosystem:develop Dec 21, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@zillionn zillionn deleted the zillionn:new-wallet-icons branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.