Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also decompose passphrases for tx and signing #817

Merged
merged 2 commits into from Dec 20, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 20, 2018

Proposed changes

Also fix the issue with Korean passphrases when sending transactions / signing messages.
Please test again by trying to send some transactions, including one with a second signature. Don't forget to set your bip39 language to Korean when creating a new wallet to test it

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@luciorubeens luciorubeens merged commit 2309a87 into develop Dec 20, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/korean-passphrase-tx branch Dec 20, 2018

@luciorubeens

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

@ItsANameToo 고마워

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.