Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add border-theme-line-separator to input fields #818

Merged
merged 3 commits into from Dec 20, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 20, 2018

#700 where input field border is too bright, this is because it uses the default light-theme color when it is supposed to use theme-line-separator color.

Proposed changes

Add border-theme-line-separator to all input fields

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@JeremiGendron
Copy link
Contributor Author

left a comment

for some reason, border-theme-input-field-border doesn't apply at all, even if put in the place of border-theme-line-separator

@zillionn

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

It looks good!

@luciorubeens
Copy link
Member

left a comment

Good catch, but border-theme-input-field-border does not apply because it was not declared in tailwind.js, do this and you do not have to add the border-theme-line-separator.

JeremiGendron added some commits Dec 20, 2018

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

@luciorubeens now only tailwind.js was changes and everything works as expected. Thanks for the help!

@luciorubeens luciorubeens merged commit dc16bd3 into ArkEcosystem:develop Dec 20, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@luciorubeens

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

@JeremiGendron thank you 👍

@JeremiGendron JeremiGendron deleted the JeremiGendron:fix/InputField-invariable-border-color branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.