Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show unconfirmed tx for type > 0 #819

Merged
merged 2 commits into from Dec 21, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 20, 2018

Proposed changes

Resolves #774

Transactions that were not a transfer did not have a recipientId, which resulted in the storeTransaction function setting a property to undefined which made the unconfirmed transaction not appear. This PR sets the sender as recipient if recipientId is undefined, which makes the unconfirmed tx show up again:

schermafbeelding 2018-12-20 om 22 28 43

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@luciorubeens luciorubeens merged commit 3e63c6b into develop Dec 21, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/unconfirmed-tx branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.