Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to translate the app #823

merged 4 commits into from Jan 8, 2019


Copy link

commented Dec 21, 2018

Types of changes

  • Docs (documentation only changes)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #823 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #823   +/-   ##
  Coverage    37.74%   37.74%           
  Files          194      194           
  Lines         4620     4620           
  Branches       887      885    -2     
  Hits          1744     1744           
  Misses        2761     2761           
  Partials       115      115

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366664e...263b194. Read the comment docs.

@j-a-m-l j-a-m-l requested review from luciorubeens and alexbarnsley Jan 8, 2019

@j-a-m-l j-a-m-l changed the title [WIP] docs: explain how to translate the app docs: explain how to translate the app Jan 8, 2019

Copy link

left a comment

Looks good 👌

@alexbarnsley alexbarnsley merged commit fc87264 into develop Jan 8, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!

@alexbarnsley alexbarnsley deleted the translation-instructions branch Jan 8, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.